linux-kernel - Re: [PATCH v3 1/1] HID: shield: Initial driver implementation with Thunderstrike support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87leiqb8xi.fsf@nvidia.com>
Date:   Mon, 17 Apr 2023 12:33:29 -0700
From:   Rahul Rameshbabu <rrameshbabu@...dia.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/1] HID: shield: Initial driver implementation with
 Thunderstrike support

Hi Randy,

Thanks for the feedback. You are correct about the styling issue in my
patch. I will fix this. I do want to bring to attention that there seem
to be a couple of kernel config options in the Kconfig file for the hid
subsystem that currently violate the styling rules.

It probably would make sense to have a clean-up patch for this issue
overall (separate from this patch, which I will correct in my next
version).

-- Rahul Rameshbabu

On Mon, 17 Apr, 2023 12:20:51 -0700 Randy Dunlap <rdunlap@...radead.org> wrote:
> According to Documentation/process/coding-style.rst, Kconfig help text should
> be indented by 2 spaces after the "help" line:
>
> 10) Kconfig configuration files
> -------------------------------
>
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different.  Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.  Example::
>
>   config AUDIT
> 	bool "Auditing support"
> 	depends on NET
> 	help
> 	  Enable auditing infrastructure that can be used with another
> 	  kernel subsystem, such as SELinux (which requires this for
> 	  logging of avc messages output).  Does not do system-call
> 	  auditing without CONFIG_AUDITSYSCALL.