linux-kernel - Re: [PATCH 1/2] drm/amd/display: mark dccg314

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0d966637-6074-4d54-a299-41d063e05310@app.fastmail.com>
Date:   Mon, 17 Apr 2023 23:14:28 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Hamza Mahfooz" <hamza.mahfooz@....com>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Harry Wentland" <harry.wentland@....com>,
        "Leo Li" <sunpeng.li@....com>,
        "Rodrigo Siqueira" <Rodrigo.Siqueira@....com>,
        "Alex Deucher" <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        "Dave Airlie" <airlied@...il.com>,
        "Daniel Vetter" <daniel@...ll.ch>
Cc:     "Nicholas Kazlauskas" <nicholas.kazlauskas@....com>,
        "Taimur Hassan" <Syed.Hassan@....com>,
        "Jasdeep Dhillon" <jdhillon@....com>,
        "Alex Hung" <alex.hung@....com>,
        "Michael Strauss" <michael.strauss@....com>,
        "Aurabindo Pillai" <aurabindo.pillai@....com>,
        "Qingqing Zhuo" <qingqing.zhuo@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] drm/amd/display: mark dccg314_init() static

On Mon, Apr 17, 2023, at 23:12, Hamza Mahfooz wrote:
> On 4/17/23 17:05, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> The newly introduced global function is not declared in a header or
>> called from another file, causing a harmless warning with sparse
>> or W=1 builds:
>> 
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: error: no previous prototype for 'dccg314_init' [-Werror=missing-prototypes]
>> 
>> Mark it static instead.
>> 
>> Fixes: 6f6869dcf415 ("drm/amd/display: prep work for root clock optimization enablement for DCN314")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> This has already been fixed as of commit 669f4ac40947 ("drm/amd/display:
> set variable dccg314_init storage-class-specifier to static") in
> amd-staging-drm-next.

Ok, thanks. I waited for a rebase on today's linux-next before posting
mine to make sure it's not already fixed, it must have just missed the
cut-off.

      Arnd