linux-kernel - Re: [PATCH V3 8/9] arm64: dts: Add ipq5018 SoC and rdp432-c2 board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c63530fc-5682-b400-2bda-547f5de75380@quicinc.com>
Date:   Mon, 17 Apr 2023 11:32:17 +0530
From:   Sricharan Ramabadhran <quic_srichara@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, <ulf.hansson@...aro.org>,
        <linus.walleij@...aro.org>, <catalin.marinas@....com>,
        <will@...nel.org>, <p.zabel@...gutronix.de>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     Varadarajan Narayanan <quic_varada@...cinc.com>,
        Gokul Sriram Palanisamy <quic_gokulsri@...cinc.com>
Subject: Re: [PATCH V3 8/9] arm64: dts: Add ipq5018 SoC and rdp432-c2 board
 support



On 4/14/2023 5:01 PM, Konrad Dybcio wrote:
> 
> 
> On 14.04.2023 12:29, Sricharan Ramabadhran wrote:
>> Add initial device tree support for the Qualcomm IPQ5018 SoC and
>> rdp432-c2 board.
>>
>> Co-developed-by: Varadarajan Narayanan <quic_varada@...cinc.com>
>> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
>> Co-developed-by: Gokul Sriram Palanisamy <quic_gokulsri@...cinc.com>
>> Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@...cinc.com>
>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@...cinc.com>
>> ---
>>   [v3] Fixed all review comments and DTS schema warnings
> This is too vague.
> 
   Ha ok, infact below is the list of changes from V2 -> V3


     *) Sorted the nodes based on address.
     *) Removed the pcie fixed clocks.
     *) Changed the board file name.
     *) Added SDHCI nodes/pins.
     *) Fixed the DT schema warnings.
     *) Fixed rest of comments.

> [...]
> 
>> +
>> +			v2m1: v2m@...0 {
>> +				compatible = "arm,gic-v2m-frame";
>> +				reg = <0x00001000 0xffd>;
> Doesn't this exceed the ranges=<> of &intc?
> 
   Right, thanks for the catch. Will fix it.

Regards,
  Sricharan