linux-kernel - Re: [PATCH 2/2] drm/amd/display: fix missing=prototypes warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <00468187-1b28-4cc6-a319-1af1acb0048f@app.fastmail.com>
Date:   Tue, 18 Apr 2023 00:10:02 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Hamza Mahfooz" <hamza.mahfooz@....com>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Harry Wentland" <harry.wentland@....com>,
        "Leo Li" <sunpeng.li@....com>,
        "Rodrigo Siqueira" <Rodrigo.Siqueira@....com>,
        "Alex Deucher" <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        "Dave Airlie" <airlied@...il.com>,
        "Daniel Vetter" <daniel@...ll.ch>
Cc:     "Lyude Paul" <lyude@...hat.com>, "Wayne Lin" <Wayne.Lin@....com>,
        "hersen wu" <hersenxs.wu@....com>,
        "Fangzhi Zuo" <Jerry.Zuo@....com>,
        "Aurabindo Pillai" <Aurabindo.Pillai@....com>,
        "Alan Liu" <HaoPing.Liu@....com>,
        "Wenjing Liu" <wenjing.liu@....com>, "Jun Lei" <Jun.Lei@....com>,
        "Alex Hung" <alex.hung@....com>, "Aric Cyr" <Aric.Cyr@....com>,
        "Qingqing Zhuo" <qingqing.zhuo@....com>,
        "Alvin Lee" <Alvin.Lee2@....com>, "Roman Li" <roman.li@....com>,
        "Jasdeep Dhillon" <jdhillon@....com>,
        "Wesley Chalmers" <Wesley.Chalmers@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drm/amd/display: fix missing=prototypes warnings

On Mon, Apr 17, 2023, at 23:17, Hamza Mahfooz wrote:
> On 4/17/23 17:05, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> Three functions in the amdgpu display driver cause -Wmissing-prototype
>> warnings:
>> 
>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1858:6: error: no previous prototype for 'is_timing_changed' [-Werror=missing-prototypes]
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:210:6: error: no previous prototype for 'is_synaptics_cascaded_panamera' [-Werror=missing-prototypes]
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: error: no previous prototype for 'optc3_wait_drr_doublebuffer_pending_clear' [-Werror=missing-prototypes]
>> 
>> is_timing_changed() is actually meant to be a global symbol, but needs
>> a proper name and prototype, while the other two can just be made static.
>> 
>> Fixes: 54c7b715b5ef ("drm/amd/display: Add DSC Support for Synaptics Cascaded MST Hub")
>> Fixes: 17ce8a6907f7 ("drm/amd/display: Add dsc pre-validation in atomic check")
>> Fixes: 8f0d304d21b3 ("drm/amd/display: Do not commit pipe when updating DRR")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> It seems like, only the changes for is_timing_changed() are in this patch.

Indeed. I made this patch a few weeks ago, and it looks like the other
two were fixed in the same way that I had in the meantime, so the other
changes got silently dropped during a rebase. I've updated the changelog
text and sent a v2 now.

      Arnd