linux-kernel - Re: [PATCH] module: remove use of uninitialized variable len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZD3XA/OBdHEhzX5q@bombadil.infradead.org>
Date:   Mon, 17 Apr 2023 16:32:19 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Tom Rix <trix@...hat.com>
Cc:     nathan@...nel.org, ndesaulniers@...gle.com,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] module: remove use of uninitialized variable len

On Mon, Apr 17, 2023 at 07:09:57PM -0400, Tom Rix wrote:
> clang build reports
> kernel/module/stats.c:307:34: error: variable
>   'len' is uninitialized when used here [-Werror,-Wuninitialized]
>         len = scnprintf(buf + 0, size - len,
>                                         ^~~
> At the start of this sequence, neither the '+ 0', nor the '- len' are needed.
> So remove them and fix using 'len' uninitalized.
> 
> Fixes: 0d4ab68ce983 ("module: add debug stats to help identify memory pressure")
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
 
Thanks, applied and pushed!

  Luis