linux-kernel - Re: [PATCH v4 09/11] PCI: rockchip: Use u32 variable to access 32-bit registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <473b7647-58ee-9a4c-b910-f22f778a058e@kernel.org>
Date:   Tue, 18 Apr 2023 08:56:29 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Rick Wertenbroek <rick.wertenbroek@...il.com>,
        alberto.dassatti@...g-vd.ch
Cc:     xxm@...k-chips.com, stable@...r.kernel.org,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Caleb Connolly <kc@...tmarketos.org>,
        Johan Jonker <jbx6244@...il.com>,
        Brian Norris <briannorris@...omium.org>,
        Corentin Labbe <clabbe@...libre.com>,
        Arnaud Ferraris <arnaud.ferraris@...labora.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Judy Hsiao <judyhsiao@...omium.org>,
        Hugh Cole-Baker <sigmaris@...il.com>,
        linux-pci@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 09/11] PCI: rockchip: Use u32 variable to access 32-bit
 registers

On 4/17/23 18:26, Rick Wertenbroek wrote:
> Previously u16 variables were used to access 32-bit registers, this
> resulted in not all of the data being read from the registers. Also
> the left shift of more than 16-bits would result in moving data out
> of the variable. Use u32 variables to access 32-bit registers
> 
> Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller")
> Cc: stable@...r.kernel.org
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@...il.com>
> Tested-by: Damien Le Moal <dlemoal@...nel.org>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>