linux-kernel - Re: [PATCH] usb: Add explicit of.h of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Apr 2023 01:36:34 +0000
From:   Chunfeng Yun (云春峰) 
        <Chunfeng.Yun@...iatek.com>
To:     "robh@...nel.org" <robh@...nel.org>,
        "Thinh.Nguyen@...opsys.com" <Thinh.Nguyen@...opsys.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb: Add explicit of.h of_platform.h include

On Mon, 2023-04-10 at 18:26 -0500, Rob Herring wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Several USB drivers use of_platform_* functions which are declared in
> of_platform.h. of_platform.h gets implicitly included by of_device.h,
> but that is going to be removed soon. Nothing else depends on
> of_device.h
> so it can be dropped.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/usb/dwc3/dwc3-am62.c           | 2 +-
>  drivers/usb/gadget/udc/rzv2m_usb3drd.c | 2 +-
>  drivers/usb/mtu3/mtu3_host.c           | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-
> am62.c
> index 173cf3579c55..4d674a243784 100644
> --- a/drivers/usb/dwc3/dwc3-am62.c
> +++ b/drivers/usb/dwc3/dwc3-am62.c
> @@ -11,7 +11,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/mfd/syscon.h>
>  #include <linux/of.h>
> -#include <linux/of_device.h>
> +#include <linux/of_platform.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/clk.h>
>  #include <linux/regmap.h>
> diff --git a/drivers/usb/gadget/udc/rzv2m_usb3drd.c
> b/drivers/usb/gadget/udc/rzv2m_usb3drd.c
> index 3c8bbf843038..8aafd1ddf126 100644
> --- a/drivers/usb/gadget/udc/rzv2m_usb3drd.c
> +++ b/drivers/usb/gadget/udc/rzv2m_usb3drd.c
> @@ -6,7 +6,7 @@
>   */
> 
>  #include <linux/io.h>
> -#include <linux/of_device.h>
> +#include <linux/of_platform.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/reset.h>
> diff --git a/drivers/usb/mtu3/mtu3_host.c
> b/drivers/usb/mtu3/mtu3_host.c
> index f3903367a6a0..177d2caf887c 100644
> --- a/drivers/usb/mtu3/mtu3_host.c
> +++ b/drivers/usb/mtu3/mtu3_host.c
> @@ -11,7 +11,7 @@
>  #include <linux/irq.h>
>  #include <linux/kernel.h>
>  #include <linux/mfd/syscon.h>
> -#include <linux/of_device.h>
> +#include <linux/of_platform.h>
>  #include <linux/regmap.h>
For mtu3 change:

Acked-by: Chunfeng Yun <chunfeng.yun@...iatek.com>

Thanks

> 
>  #include "mtu3.h"
> --
> 2.39.2
>