linux-kernel - Re: [PATCH] usb: chipidea: fix missing goto in `ci_hdrc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL411-qGHzMPopY_5u3r5Nu8NHYVaqU6JNKaGryqFjNPtoFUvQ@mail.gmail.com>
Date:   Mon, 17 Apr 2023 10:04:08 +0800
From:   Peter Chen <hzpeterchen@...il.com>
To:     Yinhao Hu <dddddd@...t.edu.cn>
Cc:     Peter Chen <peter.chen@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        hust-os-kernel-patches@...glegroups.com,
        Dongliang Mu <dzm91@...t.edu.cn>,
        Peter Chen <peter.chen@...escale.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: chipidea: fix missing goto in `ci_hdrc_probe`

On Wed, Apr 12, 2023 at 2:01 PM Yinhao Hu <dddddd@...t.edu.cn> wrote:
>
> From the comment of ci_usb_phy_init, it returns an error code if
> usb_phy_init has failed, and it should do some clean up, not just
> return directly.
>
> Fix this by goto the error handling.
>
> Fixes: 74475ede784d ("usb: chipidea: move PHY operation to core")
> Signed-off-by: Yinhao Hu <dddddd@...t.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>
> ---
>  drivers/usb/chipidea/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 281fc51720ce..25084ce7c297 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -1108,7 +1108,7 @@ static int ci_hdrc_probe(struct platform_device *pdev)
>         ret = ci_usb_phy_init(ci);
>         if (ret) {
>                 dev_err(dev, "unable to init phy: %d\n", ret);
> -               return ret;
> +               goto ulpi_exit;
>         }
>
>         ci->hw_bank.phys = res->start;
> --
> 2.34.1
>

Acked-by: Peter Chen <peter.chen@...nel.org>

Peter