linux-kernel - Re: [PATCH v2.1 2/2] x86/Documentation: Add documentation about cluster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 Apr 2023 17:23:34 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>,
        K Prateek Nayak <kprateek.nayak@....com>,
        linux-kernel@...r.kernel.org
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, hpa@...or.com, corbet@....net,
        jgross@...e.com, andrew.cooper3@...rix.com, peterz@...radead.org,
        Jason@...c4.com, thomas.lendacky@....com, puwen@...on.cn,
        x86@...nel.org, linux-doc@...r.kernel.org, oleksandr@...alenko.name
Subject: Re: [PATCH v2.1 2/2] x86/Documentation: Add documentation about
 cluster

On 4/14/23 19:24, Bagas Sanjaya wrote:
> On 4/14/23 10:17, K Prateek Nayak wrote:
>> +  - cluster_id:
>> +
>> +    A per-CPU variable containing:
>> +
>> +      - Upper bits extracted from the APIC ID.  CPUs which have the same value
>> +        in these bits share an L2 and have the same cluster_id.
>> +
>> +        CPUs for which cluster information is unavailable will show 65535
>> +        (BAD_APICID) as the cluster_id.
> "... return cluster_id of 65535 (BAD_APICID)."

Bagas, this is talking about a per-cpu variable.  Variables don't
"return" things, functions do.

I also have a request: I'd really appreciate if you could avoid
reviewing x86-related documentation.  The review comments that I've seen
coming from you have not helped x86 documentation.  They've hurt the
patches more than they have helped.