linux-kernel - Re: [PATCH] mm: rename reclaim_pages() to reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a5z7w8e7.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date:   Mon, 17 Apr 2023 10:27:12 +0800
From:   "Huang, Ying" <ying.huang@...el.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Kefeng Wang <wangkefeng.wang@...wei.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        SeongJae Park <sj@...nel.org>, Hugh Dickins <hughd@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: rename reclaim_pages() to reclaim_folios()

Matthew Wilcox <willy@...radead.org> writes:

> On Sat, Apr 15, 2023 at 05:27:16PM +0800, Kefeng Wang wrote:
>> As commit a83f0551f496 ("mm/vmscan: convert reclaim_pages() to use
>> a folio") changes the arg from page_list to folio_list, but not
>> the defination, let's correct it and rename it to reclaim_folios too.
>
> I didn't bother.  It's not inaccurate; we're reclaiming the pages
> in the folios.

What's the general rule about renaming "pages" to "folios" in function
names?  I am thinking whether it's necessary to rename migrate_pages()
to migrate_folios().  It's unnecessary?

Best Regards,
Huang, Ying