linux-kernel - Re: [PATCH net-next v2] net: lan966x: Fix lan966x_ifh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168172261811.15038.16817506134246083611.git-patchwork-notify@kernel.org>
Date:   Mon, 17 Apr 2023 09:10:18 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, UNGLinuxDriver@...rochip.com,
        aleksander.lobakin@...el.com
Subject: Re: [PATCH net-next v2] net: lan966x: Fix lan966x_ifh_get

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@...emloft.net>:

On Mon, 17 Apr 2023 09:26:41 +0200 you wrote:
> From time to time, it was observed that the nanosecond part of the
> received timestamp, which is extracted from the IFH, it was actually
> bigger than 1 second. So then when actually calculating the full
> received timestamp, based on the nanosecond part from IFH and the second
> part which is read from HW, it was actually wrong.
> 
> The issue seems to be inside the function lan966x_ifh_get, which
> extracts information from an IFH(which is an byte array) and returns the
> value in a u64. When extracting the timestamp value from the IFH, which
> starts at bit 192 and have the size of 32 bits, then if the most
> significant bit was set in the timestamp, then this bit was extended
> then the return value became 0xffffffff... . And the reason of this is
> because constants without any postfix are treated as signed longs and
> that is the reason why '1 << 31' becomes 0xffffffff80000000.
> This is fixed by adding the postfix 'ULL' to 1.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: lan966x: Fix lan966x_ifh_get
    https://git.kernel.org/netdev/net-next/c/99676a576641

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html