linux-kernel - Re: [PATCH 1/6] media: mediatek: vcodec: can`t regard getting lat buffer fail as error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5491caa1ee132672fcbd7c284451739172fdc698.camel@mediatek.com>
Date:   Mon, 17 Apr 2023 12:09:28 +0000
From:   Yunfei Dong (董云飞) 
        <Yunfei.Dong@...iatek.com>
To:     "wenst@...omium.org" <wenst@...omium.org>,
        "nfraprado@...labora.com" <nfraprado@...labora.com>,
        "nicolas@...fresne.ca" <nicolas@...fresne.ca>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "benjamin.gaignard@...labora.com" <benjamin.gaignard@...labora.com>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "frkoenig@...omium.org" <frkoenig@...omium.org>,
        "stevecho@...omium.org" <stevecho@...omium.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "hsinyi@...omium.org" <hsinyi@...omium.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH 1/6] media: mediatek: vcodec: can`t regard getting lat
 buffer fail as error

Hi AngeloGioacchino,

Thanks for your suggestion.
On Mon, 2023-04-17 at 11:18 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 17/04/23 07:48, Yunfei Dong ha scritto:
> > The speed of lat decoder is much faster than core, need to get
> > trans
> > buffer again when lat fail to get trans buffer.
> > 
> 
> The commit description is misleading, looks like you're doing
> functional
> changes, but you're just changing loglevels... and the title is also
> a
> little confusing, so.. I would propose:
> 
> media: mediatek: vcodec: Avoid unneeded error logging
> 
> Since the LAT decoder works faster than its CORE, getting the trans
> buffer may
> be done only after CORE finishes processing: avoid printing an error
> if the
> decode function returns -EAGAIN, as this means that the buffer from
> CORE is not
> yet available, but will be at a later time.
> 
> Also change the log level for calls to vdec_msg_queue_dqbuf() in H264
> and VP9
> LAT decoder drivers to avoid excessive logging.
> 

Fixed in patch v2.

> Cheers,
> Angelo
> 
Best Regards,
Yunfei Dong
> 
>