linux-kernel - [PATCH linux-next 3/3] selftests: net: udpgso_bench

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Apr 2023 20:25:04 +0800
From:   Yang Yang <yang.yang29@....com.cn>
To:     davem@...emloft.net, edumazet@...gle.com,
        willemdebruijn.kernel@...il.com
Cc:     yang.yang29@....com.cn, kuba@...nel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        netdev@...r.kernel.org, pabeni@...hat.com, shuah@...nel.org,
        zhang.yunkai@....com.cn, xu.xin16@....com.cn,
        Xuexin Jiang <jiang.xuexin@....com.cn>
Subject: [PATCH linux-next 3/3] selftests: net: udpgso_bench_rx: Fix packet number exceptions

From: Zhang Yunkai (CGEL ZTE) <zhang.yunkai@....com.cn>

The -n parameter is confusing and seems to only affect the frequency of
determining whether the time reaches 1s. However, the final print of the
program is the number of messages expected to be received, which is always
0.

bash# udpgso_bench_rx -4 -n 100
bash# udpgso_bench_tx -l 1 -4 -D "$DST"
udpgso_bench_rx: wrong packet number! got 0, expected 100

This is because the packets are always cleared after print.

Signed-off-by: Zhang Yunkai (CGEL ZTE) <zhang.yunkai@....com.cn>
Reviewed-by: xu xin (CGEL ZTE) <xu.xin16@....com.cn>
Reviewed-by: Yang Yang (CGEL ZTE) <yang.yang29@....com.cn>
Cc: Xuexin Jiang (CGEL ZTE) <jiang.xuexin@....com.cn>
---
 tools/testing/selftests/net/udpgso_bench_rx.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/udpgso_bench_rx.c b/tools/testing/selftests/net/udpgso_bench_rx.c
index 784e88b31f7d..b66bb53af19f 100644
--- a/tools/testing/selftests/net/udpgso_bench_rx.c
+++ b/tools/testing/selftests/net/udpgso_bench_rx.c
@@ -50,7 +50,7 @@ static int  cfg_rcv_timeout_ms;
 static struct sockaddr_storage cfg_bind_addr;
 
 static bool interrupted;
-static unsigned long packets, bytes;
+static unsigned long packets, total_packets, bytes;
 
 static void sigint_handler(int signum)
 {
@@ -405,6 +405,7 @@ static void do_recv(void)
 					"%s rx: %6lu MB/s %8lu calls/s\n",
 					cfg_tcp ? "tcp" : "udp",
 					bytes >> 20, packets);
+			total_packets += packets;
 			bytes = packets = 0;
 			treport = tnow + 1000;
 		}
@@ -415,7 +416,7 @@ static void do_recv(void)
 
 	if (cfg_expected_pkt_nr && (packets != cfg_expected_pkt_nr))
 		error(1, 0, "wrong packet number! got %ld, expected %d\n",
-		      packets, cfg_expected_pkt_nr);
+		      total_packets + packets, cfg_expected_pkt_nr);
 
 	if (close(fd))
 		error(1, errno, "close");
-- 
2.15.2