linux-kernel - Re: [PATCH] wifi: ath12k: fix missing unwind goto in `ath12k_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <168173568189.28224.5440053310426162831.kvalo@kernel.org>
Date:   Mon, 17 Apr 2023 12:48:06 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Li Ningke <lnk_01@...t.edu.cn>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Vasanthakumar Thiagarajan <quic_vthiagar@...cinc.com>,
        Jeff Johnson <quic_jjohnson@...cinc.com>,
        Karthikeyan Periyasamy <quic_periyasa@...cinc.com>,
        Carl Huang <quic_cjhuang@...cinc.com>,
        P Praneesh <quic_ppranees@...cinc.com>,
        hust-os-kernel-patches@...glegroups.com,
        Li Ningke <lnk_01@...t.edu.cn>,
        Dongliang Mu <dzm91@...t.edu.cn>,
        Kalle Valo <quic_kvalo@...cinc.com>,
        Bhagavathi Perumal S <quic_bperumal@...cinc.com>,
        Baochen Qiang <quic_bqiang@...cinc.com>,
        Balamurugan Selvarajan <quic_bselvara@...cinc.com>,
        ath12k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: ath12k: fix missing unwind goto in
 `ath12k_pci_probe`

Li Ningke <lnk_01@...t.edu.cn> wrote:

> Smatch complains that
> drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe() warn: 
> missing unwind goto?
> 
> In order to release the allocated resources before returning an
> error, the statement that directly returns the error is changed
> to a goto statement that first releases the resources in the error
> handling section.
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Signed-off-by: Li Ningke <lnk_01@...t.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>

Already fixed with an identical patch:

https://git.kernel.org/kvalo/ath/c/488d9a484f96

error: patch failed: drivers/net/wireless/ath/ath12k/pci.c:1195
error: drivers/net/wireless/ath/ath12k/pci.c: patch does not apply
stg import: Diff does not apply cleanly

Patch set to Rejected.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230417115921.176229-1-lnk_01@hust.edu.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches