linux-kernel - Re: linux-next: Tree for Apr 13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1558440.1681740407@warthog.procyon.org.uk>
Date:   Mon, 17 Apr 2023 15:06:47 +0100
From:   David Howells <dhowells@...hat.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     dhowells@...hat.com, Jens Axboe <axboe@...nel.dk>,
        Ayush Jain <ayush.jain3@....com>, broonie@...nel.org,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Santosh.Shukla@....com, Kalpana.Shetty@....com,
        Narasimhan V <Narasimhan.V@....com>, sfr@...b.auug.org.au
Subject: Re: linux-next: Tree for Apr 13

David Howells <dhowells@...hat.com> wrote:

> The problem might be summed up by the following snippet:
> 
> 	openat(AT_FDCWD, "/dev/loop0", O_RDONLY) = 3
> 	newfstatat(3, "", {st_mode=S_IFBLK|0660, st_rdev=makedev(0x7, 0), ...}, AT_EMPTY_PATH) = 0
> 	splice(3, NULL, 1, NULL, 1048576, 0)    = 0

Ah.  In filemap_splice_read():

	do {
		cond_resched();

		if (*ppos >= i_size_read(file_inode(in)))
			break;

but i_size_read(file_inode(in)) for a blockdev returns 0, it would seem.  What
should I use instead?

David