linux-kernel - Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpGuF_kKXMSx2bHNC7FprOfqbCp+cfdsoct9sN=1+wqtAQ@mail.gmail.com>
Date:   Tue, 18 Apr 2023 09:45:52 -0700
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Peter Xu <peterx@...hat.com>
Cc:     Matthew Wilcox <willy@...radead.org>, akpm@...ux-foundation.org,
        hannes@...xchg.org, mhocko@...e.com, josef@...icpanda.com,
        jack@...e.cz, ldufour@...ux.ibm.com, laurent.dufour@...ibm.com,
        michel@...pinasse.org, liam.howlett@...cle.com, jglisse@...gle.com,
        vbabka@...e.cz, minchan@...gle.com, dave@...olabs.net,
        punit.agrawal@...edance.com, lstoakes@...il.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        kernel-team@...roid.com
Subject: Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault
 handler retries

On Tue, Apr 18, 2023 at 8:48 AM Peter Xu <peterx@...hat.com> wrote:
>
> On Tue, Apr 18, 2023 at 04:32:27PM +0100, Matthew Wilcox wrote:
> > ... when we called clone()?  A thread by definition has a reference to
> > its own mm.
>
> Ah yes.. thanks!

re: I also had a quick look on do_exit() but I also didn't see where
do we e.g. wait for all the threads to stop before recycles a mm.

We recycle mm after all refcounts are dropped in the exit path:
  do_exit
    exit_mm
      mmput(if !mm->mm_users)
        mmdrop(if !mm->mm_count)
          free_mm

>
> --
> Peter Xu
>