| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <c27e07d2-8eb1-16a8-4619-280967fc0de9@roeck-us.net>
Date: Tue, 18 Apr 2023 10:17:38 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: nick.hawkins@....com, verdun@....com, linus.walleij@...aro.org,
brgl@...ev.pl, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, jdelvare@...e.com,
linux@...linux.org.uk, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-hwmon@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 1/9] gpio: gxp: Add HPE GXP GPIO
On 4/18/23 08:28, nick.hawkins@....com wrote:
> From: Nick Hawkins <nick.hawkins@....com>
>
> The GXP SoC supports GPIO on multiple interfaces: Host, CPLD and Soc
> pins. The interface from CPLD and Host are interruptable from vic0
> and vic1. This driver allows support for both of these interfaces
> through the use of different compatible bindings.
>
> Signed-off-by: Nick Hawkins <nick.hawkins@....com>
> ---
> drivers/gpio/Kconfig | 9 +
> drivers/gpio/Makefile | 1 +
> drivers/gpio/gpio-gxp.c | 1056 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 1066 insertions(+)
> create mode 100644 drivers/gpio/gpio-gxp.c
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 13be729710f2..47435307698c 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1235,6 +1235,15 @@ config HTC_EGPIO
> several HTC phones. It provides basic support for input
> pins, output pins, and IRQs.
>
> +config GPIO_GXP
> + tristate "GXP GPIO support"
> + depends on ARCH_HPE_GXP
> + select GPIOLIB_IRQCHIP
> + help
> + Say Y here to support GXP GPIO controllers. It provides
> + support for the multiple GPIO interfaces available to be
> + available to the Host.
> +
> config GPIO_JANZ_TTL
> tristate "Janz VMOD-TTL Digital IO Module"
> depends on MFD_JANZ_CMODIO
> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index c048ba003367..a7ce0ab097aa 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -63,6 +63,7 @@ obj-$(CONFIG_GPIO_FTGPIO010) += gpio-ftgpio010.o
> obj-$(CONFIG_GPIO_GE_FPGA) += gpio-ge.o
> obj-$(CONFIG_GPIO_GPIO_MM) += gpio-gpio-mm.o
> obj-$(CONFIG_GPIO_GRGPIO) += gpio-grgpio.o
> +obj-$(CONFIG_GPIO_GXP) += gpio-gxp.o
> obj-$(CONFIG_GPIO_GW_PLD) += gpio-gw-pld.o
> obj-$(CONFIG_GPIO_HISI) += gpio-hisi.o
> obj-$(CONFIG_GPIO_HLWD) += gpio-hlwd.o
> diff --git a/drivers/gpio/gpio-gxp.c b/drivers/gpio/gpio-gxp.c
> new file mode 100644
> index 000000000000..86f69174434d
> --- /dev/null
> +++ b/drivers/gpio/gpio-gxp.c
> @@ -0,0 +1,1056 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/* Copyright (C) 2023 Hewlett-Packard Enterprise Development Company, L.P. */
> +
> +#include <linux/gpio.h>
> +#include <linux/init.h>
> +#include <linux/interrupt.h>
> +#include <linux/irq.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +
> +#define GPIDATL 0x40
> +#define GPIDATH 0x60
> +#define GPODATL 0xb0
> +#define GPODATH 0xb4
> +#define GPODAT2L 0xf8
> +#define GPODAT2H 0xfc
> +#define GPOOWNL 0x110
> +#define GPOOWNH 0x114
> +#define GPOOWN2L 0x118
> +#define GPOOWN2H 0x11c
> +
> +#define GPIO_DIR_OUT 0
> +#define GPIO_DIR_IN 1
> +
> +#define PGOOD_MASK 1
> +
> +#define PLREG_INT_GRP_STAT_MASK 0x8
> +#define PLREG_INT_HI_PRI_EN 0xC
> +#define PLREG_INT_GRP5_BASE 0x31
> +#define PLREG_INT_GRP6_BASE 0x35
> +#define PLREG_INT_GRP5_FLAG 0x30
> +#define PLREG_INT_GRP6_FLAG 0x34
> +#define PLREG_INT_GRP5_PIN_BASE 59
> +#define PLREG_INT_GRP6_PIN_BASE 90
> +
> +enum pl_gpio_pn {
> + IOP_LED1 = 0,
> + IOP_LED2,
> + IOP_LED3,
> + IOP_LED4,
> + IOP_LED5,
> + IOP_LED6,
> + IOP_LED7,
> + IOP_LED8,
> + FAN1_INST = 8,
> + FAN2_INST,
> + FAN3_INST,
> + FAN4_INST,
> + FAN5_INST,
> + FAN6_INST,
> + FAN7_INST,
> + FAN8_INST,
> + FAN1_FAIL,
> + FAN2_FAIL,
> + FAN3_FAIL,
> + FAN4_FAIL,
> + FAN5_FAIL,
> + FAN6_FAIL,
> + FAN7_FAIL,
> + FAN8_FAIL,
> + LED_IDENTIFY = 56,
> + LED_HEALTH_RED,
> + LED_HEALTH_AMBER,
> + PWR_BTN_INT = 59,
> + UID_PRESS_INT,
> + SLP_INT,
> + ACM_FORCE_OFF = 70,
> + ACM_REMOVED,
> + ACM_REQ_N,
> + PSU1_INST,
> + PSU2_INST,
> + PSU3_INST,
> + PSU4_INST,
> + PSU5_INST,
> + PSU6_INST,
> + PSU7_INST,
> + PSU8_INST,
> + PSU1_AC,
> + PSU2_AC,
> + PSU3_AC,
> + PSU4_AC,
> + PSU5_AC,
> + PSU6_AC,
> + PSU7_AC,
> + PSU8_AC,
> + PSU1_DC,
> + PSU2_DC,
> + PSU3_DC,
> + PSU4_DC,
> + PSU5_DC,
> + PSU6_DC,
> + PSU7_DC,
> + PSU8_DC
> +};
> +
> +enum plreg_gpio_pn {
> + RESET = 192,
> + NMI_OUT = 193,
> + VPBTN = 210,
> + PGOOD,
> + PERST,
> + POST_COMPLETE,
> +};
> +
> +struct gxp_gpio_drvdata {
> + struct regmap *csm_map;
> + void __iomem *fn2_vbtn;
> + struct regmap *fn2_stat;
> + struct regmap *vuhc0_map;
> + void __iomem *vbtn;
> + struct regmap *pl_led;
> + struct regmap *pl_health;
> + struct regmap *pl_int;
> + struct gpio_chip chip;
> + int irq;
> +};
> +
> +extern u8 get_psu_inst(void);
> +extern u8 get_psu_ac(void);
> +extern u8 get_psu_dc(void);
> +extern u8 get_fans_installed(void);
> +extern u8 get_fans_failed(void);
> +
This is not information which should be reported through a gpio driver.
Besides, the functions don't exist at this point in the series,
and there should be no extern declarations in source files.
If you want to model fan or psu information through gpio, drop
the hwmon drivers and implement reading the status here, then use
the existing gpio-fan hwmon driver to report it in the hwmon subsystem.
Guenter
Powered by blists - more mailing lists