linux-kernel - Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Apr 2023 13:24:12 -0400
From:   Waiman Long <longman@...hat.com>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     stable@...r.kernel.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
        jonathanh@...dia.com, f.fainelli@...il.com,
        sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de,
        Tejun Heo <tj@...nel.org>,
        Michal Koutný <mkoutny@...e.com>
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review


On 4/18/23 11:08, Naresh Kamboju wrote:
> On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
>> This is the start of the stable review cycle for the 5.10.178 release.
>> There are 124 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>          https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
>> or in the git tree and branch at:
>>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
> Following build errors noticed on 5.15 and 5.10.,
>
>
>> Waiman Long <longman@...hat.com>
>>      cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
> kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
> (first use in this function); did you mean 'cgroup_put'?
>   2941 |         lockdep_assert_held(&cgroup_mutex);
>        |                              ^~~~~~~~~~~~
>
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
>
> Suspected commit,
> cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.

Oh, cgroup_mutex needs the recent commit 354ed59744295 ("mm: multi-gen 
LRU: kill switch") to make it available in include/linux/cgroup.h. I did 
my testing with a debug Kconfig and so didn't catch that. This line can 
be safely removed.

Regards,
Longman