linux-kernel - Re: [PATCH v2] Drivers: hv: move panic report code from vmbus to hv early init code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZD7iT/+Uil3jTuNO@liuwe-devbox-debian-v2>
Date:   Tue, 18 Apr 2023 18:32:47 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
Cc:     "longli@...uxonhyperv.com" <longli@...uxonhyperv.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        Long Li <longli@...rosoft.com>
Subject: Re: [PATCH v2] Drivers: hv: move panic report code from vmbus to hv
 early init code

On Mon, Apr 17, 2023 at 07:28:04PM +0000, Wei Liu wrote:
> On Sat, Apr 15, 2023 at 06:16:11PM +0000, Michael Kelley (LINUX) wrote:
> > From: longli@...uxonhyperv.com <longli@...uxonhyperv.com> Sent: Thursday, April 13, 2023 6:27 PM
> > > 
> > > The panic reporting code was added in commit 81b18bce48af
> > > ("Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic")
> > > 
> > > It was added to the vmbus driver. The panic reporting has no dependence
> > > on vmbus, and can be enabled at an earlier boot time when Hyper-V is
> > > initialized.
> > > 
> > > This patch moves the panic reporting code out of vmbus. There is no
> > > functionality changes. During moving, also refactored some cleanup
> > > functions into hv_kmsg_dump_unregister(), and removed unused function
> > > hv_alloc_hyperv_page().
> > > 
> > > Signed-off-by: Long Li <longli@...rosoft.com>
> > > ---
> > > 
> > > Change log v2:
> > > 1. Check on hv_is_isolation_supported() before reporting crash dump
> > > 2. Remove hyperv_report_reg(), inline the check condition instead
> > > 3. Remove the test NULL on hv_panic_page when freeing it
> > > 
> > >  drivers/hv/hv.c                |  36 ------
> > >  drivers/hv/hv_common.c         | 229 +++++++++++++++++++++++++++++++++
> > >  drivers/hv/vmbus_drv.c         | 199 ----------------------------
> > >  include/asm-generic/mshyperv.h |   1 -
> > >  4 files changed, 229 insertions(+), 236 deletions(-)
> > 
> > Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
> 
> Applied to hyperv-next. Thanks.

This broke allmodconfig. I've removed it from the tree. Please fix and
resend.

Thanks,
Wei.