linux-kernel - [PATCH] dmaengine: virt-dma: fix a potential NULL-pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230418191603.2291521-1-roman.gushchin@linux.dev>
Date:   Tue, 18 Apr 2023 12:16:03 -0700
From:   Roman Gushchin <roman.gushchin@...ux.dev>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        Roman Gushchin <roman.gushchin@...ux.dev>
Subject: [PATCH] dmaengine: virt-dma: fix a potential NULL-pointer dereference

vchan_complete() contains a potential NULL-pointer dereference:
the vd variable is checked for being non-NULL under a spinlock,
but few lines below &vd->tx_result is passed as a second arg to
dmaengine_desc_callback_invoke() unconditionally.

This issue was spotted by looking into the code, I'm not aware of
any real world consequences. It seems like dmaengine_desc_callback_invoke()
is never using the second argument in cases when vd is NULL, this is
why we haven't seen any crashes.

To make it safer, let's pass NULL to dmaengine_desc_callback_invoke()
if vd is NULL.

Signed-off-by: Roman Gushchin <roman.gushchin@...ux.dev>
---
 drivers/dma/virt-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/virt-dma.c b/drivers/dma/virt-dma.c
index a6f4265be0c9..0c46ad18dae1 100644
--- a/drivers/dma/virt-dma.c
+++ b/drivers/dma/virt-dma.c
@@ -98,7 +98,7 @@ static void vchan_complete(struct tasklet_struct *t)
 	}
 	spin_unlock_irq(&vc->lock);

-	dmaengine_desc_callback_invoke(&cb, &vd->tx_result);
+	dmaengine_desc_callback_invoke(&cb, vd ? &vd->tx_result : NULL);

 	list_for_each_entry_safe(vd, _vd, &head, node) {
 		dmaengine_desc_get_callback(&vd->tx, &cb);
-- 
2.40.0