linux-kernel - Re: [PATCH] mm: fix printk format within cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230418123338.3b85a013cf6ce1fcb3677ae2@linux-foundation.org>
Date:   Tue, 18 Apr 2023 12:33:38 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     "zhaoyang.huang" <zhaoyang.huang@...soc.com>,
        Minchan Kim <minchan@...nel.org>,
        Joonsoo Kim <iamjoonsoo.kim@....com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Zhaoyang Huang <huangzhaoyang@...il.com>, ke.wang@...soc.com
Subject: Re: [PATCH] mm: fix printk format within cma

On Tue, 18 Apr 2023 04:38:24 +0100 Matthew Wilcox <willy@...radead.org> wrote:

> On Tue, Apr 18, 2023 at 11:33:09AM +0800, zhaoyang.huang wrote:
> > cma and page pointer printed via %p are hash value which make debug to be hard.
> > change them to %px.
> 
> Why does printing the page pointer make any sense at all?  Surely the
> PFN makes much more sense.

I suppose one could correlate a particular hashed pointer with other
debug output, see "ah, that's the same page".  In which case one
doesn't really care whether or not the address is hashed - it's just a
cookie.  This sounds thin.

I doubt if a lot of thought went into the printk.  If the page pointer
isn't useful then how about we simply remove it from the message?