linux-kernel - Re: [PATCH v7 09/12] clk: nuvoton: Add clock driver for ma35d1 clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Apr 2023 13:23:51 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jacky Huang <ychuang570808@...il.com>, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        lee@...nel.org, mturquette@...libre.com, p.zabel@...gutronix.de,
        robh+dt@...nel.org
Cc:     devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        arnd@...db.de, schung@...oton.com, mjchen@...oton.com,
        Jacky Huang <ychuang3@...oton.com>
Subject: Re: [PATCH v7 09/12] clk: nuvoton: Add clock driver for ma35d1 clock controller

Quoting Jacky Huang (2023-04-14 20:58:57)
> >> diff --git a/drivers/clk/nuvoton/clk-ma35d1.h b/drivers/clk/nuvoton/clk-ma35d1.h
> >> new file mode 100644
> >> index 000000000000..28c60f081788
> >> --- /dev/null
> >> +++ b/drivers/clk/nuvoton/clk-ma35d1.h
> >> @@ -0,0 +1,123 @@
> >> +/* SPDX-License-Identifier: GPL-2.0-only */
> >> +/*
> >> + * Copyright (C) 2023 Nuvoton Technology Corp.
> >> + * Author: Chi-Fang Li <cfli0@...oton.com>
> >> + */
> >> +
> >> +#ifndef __DRV_CLK_NUVOTON_MA35D1_H
> >> +#define __DRV_CLK_NUVOTON_MA35D1_H
> > Is this header included in one C file? If so, remove the header file and
> > put the contents in the C file.
> 
> Both clk-ma35d1.c and clk-ma35d1-pll.c include this header file.
> 

Do they both use all the defines from it? Move as much as possible out
of this header file and put them in the only C file that uses it.