[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230418214701.4qky77rsxxytyoc2@treble>
Date: Tue, 18 Apr 2023 14:47:01 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Joan Bruguera Micó <joanbrugueram@...il.com>
Cc: i.pear@...look.com, acme@...nel.org, alan.maguire@...cle.com,
alexandref75@...il.com, bpf@...r.kernel.org, dxu@...uu.xyz,
jforbes@...hat.com, linux-kernel@...r.kernel.org,
olsajiri@...il.com, peterz@...radead.org, ptalbert@...hat.com,
yhs@...com
Subject: Re: [PATCH] vmlinux.lds.h: Discard .note.gnu.property section
On Sun, Apr 16, 2023 at 07:02:19PM +0000, Joan Bruguera Micó wrote:
> Two small nitpicks:
>
> > Link: https://lkml.kernel.org/lkml/57830c30-cd77-40cf-9cd1-3bb608aa602e@app.fastmail.com
>
> This link is "semi-broken", it should go to /bpf/ instead of /lkml/.
>
> > /DISCARD/ : { *(.note.GNU-stack) } \
> > + /DISCARD/ : { *(.note.gnu.property) } \
>
> Both discards can go in the same DISCARD block.
> (just style; it's how it's most often done in other linker scripts)
Thanks. I also noticed the comment above the change needs an update.
Posting v2 shortly.
--
Josh
Powered by blists - more mailing lists