[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZD8QTOsWQ0SscOYz@bombadil.infradead.org>
Date: Tue, 18 Apr 2023 14:49:00 -0700
From: Luis Chamberlain <mcgrof@...nel.org>
To: Hugh Dickins <hughd@...gle.com>
Cc: akpm@...ux-foundation.org, willy@...radead.org, brauner@...nel.org,
linux-mm@...ck.org, p.raghav@...sung.com, da.gomez@...sung.com,
a.manzanares@...sung.com, dave@...olabs.net, yosryahmed@...gle.com,
keescook@...omium.org, patches@...ts.linux.dev,
linux-kernel@...r.kernel.org, David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH v2 5/6] shmem: update documentation
On Tue, Apr 18, 2023 at 02:41:07PM -0700, Hugh Dickins wrote:
> On Tue, 18 Apr 2023, Luis Chamberlain wrote:
> > On Mon, Apr 17, 2023 at 10:29:59PM -0700, Hugh Dickins wrote:
> > > On Thu, 9 Mar 2023, Luis Chamberlain wrote:
> > >
> > > > Update the docs to reflect a bit better why some folks prefer tmpfs
> > > > over ramfs and clarify a bit more about the difference between brd
> > > > ramdisks.
> > > >
> > > > While at it, add THP docs for tmpfs, both the mount options and the
> > > > sysfs file.
> > >
> > > Okay: the original canonical reference for THP options on tmpfs has
> > > been Documentation/admin-guide/mm/transhuge.rst. You're right that
> > > they would be helpful here too: IIRC (but I might well be confusing
> > > with our Google tree) we used to have them documented in both places,
> > > but grew tired of keeping the two in synch. You're volunteering to
> > > do so! so please check now that they tell the same story.
> >
> > Hehe. Sure, we should just make one point to the other. Which one should
> > be the authoritive source?
>
> Documentation/admin-guide/mm/transhuge.rst has been the authoritative
> source up until this patch, so I suggest it remain so; but good if you
> point to it from this Doc - unless in reading it you find that actually
> its account is wrong. (Haha, it refers to fadvise too, never mind that.)
Yeah I'll make the tmpfs kdoc point to the transhuge.rst page. I think
that's possible.
> But the man page is more important than either, so it would be good to
> point to that too.
Sure I'll have the tmpfs kdoc also point to the tmpfs man page.
> Mention the "huge=" option in this document, but
> point to elsewhere for the detail of its values.
Sounds good.
Luis
Powered by blists - more mailing lists