linux-kernel - Re: [PATCH] ALSA: hda/hdmi: Remove some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877cu9685j.wl-tiwai@suse.de>
Date:   Tue, 18 Apr 2023 08:01:28 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        alsa-devel@...a-project.org
Subject: Re: [PATCH] ALSA: hda/hdmi: Remove some dead code

On Mon, 17 Apr 2023 07:41:48 +0200,
Christophe JAILLET wrote:
> 
> These snd_BUG_ON() can never trigger, so just remove them to save a few
> LoC.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> This patch is speculative. Maybe the other "if"s should be removed and the
> error code returned instead.
> 
> I chose to remove these ones and the corresponding error code, because it
> seems that it is already handled this way in hdmi_pcm_open().
> 
> I don't know the code enough, so it is only my guess.
> 
> Review with care :)

A sanity check is merely a sanity check, and we haven't got report
hitting this, so this should be fine.  Let's cross fingers.


thanks,

Takashi