linux-kernel - Re: [PATCH] xfs: scrub: remove duplicate include headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230418000813.GB360889@frogsfrogsfrogs>
Date:   Mon, 17 Apr 2023 17:08:13 -0700
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     ye.xingchen@....com.cn
Cc:     dchinner@...hat.com, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: scrub: remove duplicate include headers

On Mon, Apr 17, 2023 at 04:13:07PM +0800, ye.xingchen@....com.cn wrote:
> From: Ye Xingchen <ye.xingchen@....com.cn>
> 
> xfs_trans_resv.h and xfs_mount.h are included more than once.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>
> ---
>  fs/xfs/scrub/health.c   | 2 --
>  fs/xfs/scrub/refcount.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/fs/xfs/scrub/health.c b/fs/xfs/scrub/health.c
> index d2b2a1cb6533..66e99b0f6049 100644
> --- a/fs/xfs/scrub/health.c
> +++ b/fs/xfs/scrub/health.c
> @@ -7,8 +7,6 @@
>  #include "xfs_fs.h"
>  #include "xfs_shared.h"
>  #include "xfs_format.h"
> -#include "xfs_trans_resv.h"
> -#include "xfs_mount.h"
>  #include "xfs_btree.h"
>  #include "xfs_trans_resv.h"
>  #include "xfs_mount.h"

The convention (AFAICT) for include order is xfs_trans_resv -> xfs_mount
-> xfs_btree.h...

> diff --git a/fs/xfs/scrub/refcount.c b/fs/xfs/scrub/refcount.c
> index ed5eb367ce49..04d216261f36 100644
> --- a/fs/xfs/scrub/refcount.c
> +++ b/fs/xfs/scrub/refcount.c

Please check the list before sending duplicate diffs.

--D

> @@ -7,8 +7,6 @@
>  #include "xfs_fs.h"
>  #include "xfs_shared.h"
>  #include "xfs_format.h"
> -#include "xfs_trans_resv.h"
> -#include "xfs_mount.h"
>  #include "xfs_btree.h"
>  #include "xfs_rmap.h"
>  #include "xfs_refcount.h"
> -- 
> 2.25.1