linux-kernel - Re: [PATCH v4 4/4] counter: 104-quad-8: Migrate to the regmap API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Apr 2023 10:44:57 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     William Breathitt Gray <william.gray@...aro.org>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Johannes Berg <johannes.berg@...el.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v4 4/4] counter: 104-quad-8: Migrate to the regmap API

On Mon, Apr 17, 2023 at 03:50:50PM -0400, William Breathitt Gray wrote:
> The regmap API supports IO port accessors so we can take advantage of
> regmap abstractions rather than handling access to the device registers
> directly in the driver. With regmap we get boundary checks, read-write
> permissions, operation synchronization locks, and more for free. Most
> important of all, rather than rolling our own we utilize implementations
> that are known to work and gain from any future improvements and fixes
> that come.

...

>  - Use "int ret" for regmap_* return values throughout for consistency

Looking into it I would think it might be better to have a precursor patch.
But it's up to you. It looks good now.

-- 
With Best Regards,
Andy Shevchenko