linux-kernel - Re: [PATCH] media: nxp: ignore unused suspend operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Apr 2023 11:20:49 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "laurent.pinchart" <laurent.pinchart@...asonboard.com>,
        "Hans Verkuil" <hverkuil@...all.nl>
Cc:     "Arnd Bergmann" <arnd@...nel.org>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Shawn Guo" <shawnguo@...nel.org>,
        "Sascha Hauer" <s.hauer@...gutronix.de>,
        "Dong Aisheng" <aisheng.dong@....com>,
        "Guoniu Zhou" <guoniu.zhou@....com>,
        "Stefan Riedmueller" <s.riedmueller@...tec.de>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        "Fabio Estevam" <festevam@...il.com>,
        "NXP Linux Team" <linux-imx@....com>,
        "Christian Hemp" <c.hemp@...tec.de>,
        "Jacopo Mondi" <jacopo@...ndi.org>, linux-media@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: nxp: ignore unused suspend operations

On Tue, Apr 18, 2023, at 10:19, Laurent Pinchart wrote:
> On Tue, Apr 18, 2023 at 10:04:13AM +0200, Hans Verkuil wrote:
>> Hi Arnd,
>> 
>> On 18/04/2023 09:15, Arnd Bergmann wrote:
>> > From: Arnd Bergmann <arnd@...db.de>
>> > 
>> > gcc warns about some functions being unused when CONFIG_PM is
>> > disabled:
>> 
>> ???
>> 
>> The Kconfig has a:
>> 
>>         depends on HAS_DMA && PM
>> 
>> So how can this be compiled with CONFIG_PM not set?
>> 
>> Am I missing something?
>
> The warning appears when CONFIG_PM_SLEEP is disabled. The pm_ptr()
> change is thus not useful, but the switch to SYSTEM_SLEEP_PM_OPS() and
> RUNTIME_PM_OPS() make a difference.

I sent a v3 now. I ended up leaving the pm_ptr() in here, based on
the recommended usage of the new macros.

    Arnd