linux-kernel - Re: [PATCH v4 1/2] thermal: mediatek: use devm_of_iomap to avoid resource leak in mtk_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7ed8963-4669-be63-0769-50a2641242c7@collabora.com>
Date:   Tue, 18 Apr 2023 11:25:47 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Kang Chen <void0red@...t.edu.cn>, error27@...il.com
Cc:     amitk@...nel.org, bchihi@...libre.com, daniel.lezcano@...aro.org,
        daniel@...rotopia.org, dzm91@...t.edu.cn, henry.yen@...iatek.com,
        hust-os-kernel-patches@...glegroups.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-pm@...r.kernel.org,
        matthias.bgg@...il.com, rafael@...nel.org, rdunlap@...radead.org,
        rui.zhang@...el.com, void0red@...il.com
Subject: Re: [PATCH v4 1/2] thermal: mediatek: use devm_of_iomap to avoid
 resource leak in mtk_thermal_probe

Il 17/04/23 14:55, Kang Chen ha scritto:
> Smatch reports:
> 1. mtk_thermal_probe() warn: 'apmixed_base' from of_iomap() not released.
> 2. mtk_thermal_probe() warn: 'auxadc_base' from of_iomap() not released.
> 
> The original code forgets to release iomap resource when handling errors,
> fix it by switch to devm_of_iomap.
> 
> Fixes: 89945047b166 ("thermal: mediatek: Add tsensor support for V2 thermal system")
> Signed-off-by: Kang Chen <void0red@...t.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>

Good job!

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>