linux-kernel - Re: [PATCH] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87leip4j8q.wl-tiwai@suse.de>
Date:   Tue, 18 Apr 2023 11:44:53 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     reaperli <reaperlioc@...nfly.com>
Cc:     <perex@...ex.cz>, <tiwai@...e.com>, <linux-kernel@...r.kernel.org>,
        jasontao <jasontao@...nfly.com>, alsa-devel@...a-project.org
Subject: Re: [PATCH] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs.

On Tue, 18 Apr 2023 10:33:12 +0200,
reaperli wrote:
> 
> From: jasontao <jasontao@...nfly.com>
> 
> Add a set of HD Audio PCI IDS, and the HDMI codec vendor IDs for
> Glenfly Arise.
> 
> Signed-off-by: jasontao <jasontao@...nfly.com>
> Signed-off-by: reaperli <reaperlioc@...nfly.com>

The patch looks OK now, but could you submit to alsa-devel ML at the
next time?

About details in the patch:

> @@ -1743,6 +1745,8 @@ static int default_bdl_pos_adj(struct azx *chip)
>  	}
>  
>  	switch (chip->driver_type) {
> +	case AZX_DRIVER_GFHDMI:
> +		return 128;

So this looks pretty high in comparison with other chips.
It means that the actual position is much behind the reported
position.  Due to a large FIFO?  Or what reason?

> @@ -1859,6 +1863,9 @@ static int azx_first_init(struct azx *chip)
>  	}
>  #endif
>  
> +	if (chip->driver_type == AZX_DRIVER_GFHDMI)
> +		bus->polling_mode = 1;

This looks odd, too.  Doesn't the hardware give any interrupt back
upon the CORB/RIRB response?

> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -4489,6 +4489,18 @@ static int patch_via_hdmi(struct hda_codec *codec)
>  	return patch_simple_hdmi(codec, VIAHDMI_CVT_NID, VIAHDMI_PIN_NID);
>  }
>  
> +static int patch_gf_hdmi(struct hda_codec *codec)
> +{
> +	int err;
> +
> +	err = patch_generic_hdmi(codec);
> +	if (err)
> +		return err;
> +
> +	codec->no_sticky_stream = 1;

This hack is needed for what reason?


thanks,

Takashi