linux-kernel - Re: [PATCH 1/3] dt-bindings: timer: rockchip: Drop superfluous rk3288 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2fe7e09-024c-b3f7-c7a6-0c2981cb3ba3@collabora.com>
Date:   Tue, 18 Apr 2023 13:34:15 +0300
From:   Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To:     Heiko Stübner <heiko@...ech.de>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        Sugar Zhang <sugar.zhang@...k-chips.com>,
        Shreeya Patel <shreeya.patel@...labora.com>,
        Kever Yang <kever.yang@...k-chips.com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH 1/3] dt-bindings: timer: rockchip: Drop superfluous rk3288
 compatible

On 4/18/23 13:26, Heiko Stübner wrote:
> Am Dienstag, 18. April 2023, 11:53:42 CEST schrieb Cristian Ciocaltea:
>> The compatible string for Rockchip RK3288 is provided in both the 'enum'
>> and the subsequent 'const' item. Drop the unnecessary entry from the
>> enum.
> 
> And the actual rk3288-timer case is handled in the separate
> 	- const: rockchip,rk3288-timer
> at the top of the list too.

Right, in total there were 3 occurrences of this compatible string.

>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> 
> Reviewed-by: Heiko Stuebner <heiko@...ech.de>
> 

Thanks for the quick review!

Regards,
Cristian