linux-kernel - Re: arch/riscv/net/bpf_jit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871qkh9zj8.fsf@all.your.base.are.belong.to.us>
Date:   Tue, 18 Apr 2023 13:54:03 +0200
From:   Björn Töpel <bjorn@...nel.org>
To:     Aleksandr Nogikh <nogikh@...gle.com>, pulehui@...wei.com,
        bpf@...r.kernel.org
Cc:     linux-riscv@...ts.infradead.org,
        LKML <linux-kernel@...r.kernel.org>,
        syzkaller <syzkaller@...glegroups.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>
Subject: Re: arch/riscv/net/bpf_jit_comp64.c build error

Aleksandr Nogikh <nogikh@...gle.com> writes:

> Hi Pu Lehui,
>
> I'm writing to you regarding your following patch.
>
> Author: Pu Lehui <pulehui@...wei.com>
> Date:   Wed Feb 15 21:52:04 2023 +0800
>
>     riscv, bpf: Add bpf_arch_text_poke support for RV64
>
> When trying to compile the "fixes" branch of the
> "git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git" tree,
> syzbot gets the following error:
>
> arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_arch_text_poke':
> arch/riscv/net/bpf_jit_comp64.c:691:9: error: implicit declaration of
> function 'patch_text'; did you mean 'path_get'?
> [-Werror=implicit-function-declaration]
>   691 |   ret = patch_text(ip, new_insns, ninsns);
>       |         ^~~~~~~~~~
>       |         path_get
>
> FWIW the compiler is riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1
> 20210110, GNU ld (GNU Binutils for Debian) 2.35.2.
>
> Could you please take a look?

Randy sent a fix for this [1], which went in via the BPF tree. Pull in
commit 2d311f480b52 ("riscv, bpf: Fix patch_text implicit declaration").


Björn

[1] https://lore.kernel.org/linux-riscv/20230227072016.14618-1-rdunlap@infradead.org/