linux-kernel - Re: [PATCH v2] docs: f2fs: specify extent cache for read explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87354xe1zi.fsf@meer.lwn.net>
Date:   Tue, 18 Apr 2023 07:47:29 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Bagas Sanjaya <bagasdotme@...il.com>,
        Yangtao Li <frank.li@...o.com>,
        Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <chao@...nel.org>
Cc:     linux-f2fs-devel@...ts.sourceforge.net, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] docs: f2fs: specify extent cache for read explicitly

Bagas Sanjaya <bagasdotme@...il.com> writes:

> On 4/17/23 11:41, Yangtao Li wrote:
>> Let's descrbie it's read extent cache.
>
> "Clarify the fact that extent_cache and noextent_cache toggle read
> extent cache on or off."

Please stop nit-picking patches.  This is good enough, though I might
fix the "describe" typo on the way in.

>> -extent_cache		 Enable an extent cache based on rb-tree, it can cache
>> -			 as many as extent which map between contiguous logical
>> +extent_cache		 Enable a read extent cache based on rb-tree, it can cache
> "... . It can cache ..."

Bagas.  Enough.  Seriously.

>>  noinline_data		 Disable the inline data feature, inline data feature is
>>  			 enabled by default.
>
> "Disable inline data feature, for which the feature is enabled by
> default." (submit as separate patch).

And please stop trying to make additional work for others.  If you want
to improve something, submit a patch yourself.

jon