linux-kernel - Re: [PATCH] module: stats: fix invalid_mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c72c3140-0beb-22fc-1231-785f454c3fc8@infradead.org>
Date:   Tue, 18 Apr 2023 07:20:25 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-modules@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] module: stats: fix invalid_mod_bytes typo



On 4/18/23 00:17, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This was caught by randconfig builds but does not show up in
> build testing without CONFIG_MODULE_DECOMPRESS:
> 
> kernel/module/stats.c: In function 'mod_stat_bump_invalid':
> kernel/module/stats.c:229:42: error: 'invalid_mod_byte' undeclared (first use in this function); did you mean 'invalid_mod_bytes'?
>   229 |   atomic_long_add(info->compressed_len, &invalid_mod_byte);
>       |                                          ^~~~~~~~~~~~~~~~
>       |                                          invalid_mod_bytes
> 
> Fixes: 0d4ab68ce983 ("module: add debug stats to help identify memory pressure")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
> This was probably already reported, sending the fix just in case everyone
> else else missed it so far.
> ---
>  kernel/module/stats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/module/stats.c b/kernel/module/stats.c
> index cdcd60695399..32959ec9581f 100644
> --- a/kernel/module/stats.c
> +++ b/kernel/module/stats.c
> @@ -226,7 +226,7 @@ void mod_stat_bump_invalid(struct load_info *info, int flags)
>  	atomic_inc(&failed_load_modules);
>  #if defined(CONFIG_MODULE_DECOMPRESS)
>  	if (flags & MODULE_INIT_COMPRESSED_FILE)
> -		atomic_long_add(info->compressed_len, &invalid_mod_byte);
> +		atomic_long_add(info->compressed_len, &invalid_mod_bytes);
>  #endif
>  }
>  

-- 
~Randy