linux-kernel - Re: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b33d2762-6769-15d1-6f7f-ca24feb6aa1b@quicinc.com>
Date:   Tue, 18 Apr 2023 20:54:19 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        <linux-kernel@...r.kernel.org>,
        <linux-trace-kernel@...r.kernel.org>
CC:     Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] tracing/timer: Add missing hrtimer modes to
 decode_hrtimer_mode().



On 4/18/2023 8:08 PM, Sebastian Andrzej Siewior wrote:
> The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
> since these modes are not decoded. The author was not aware of the fancy
> decoding function which makes the life easier.
> 
> Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
> modes.
> 
> Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Good catch.
Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>

-Mukesh

> ---
>   include/trace/events/timer.h | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h
> index 2e713a7d9aa3a..5d43751a766c6 100644
> --- a/include/trace/events/timer.h
> +++ b/include/trace/events/timer.h
> @@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel,
>   		{ HRTIMER_MODE_ABS_SOFT,	"ABS|SOFT"	},	\
>   		{ HRTIMER_MODE_REL_SOFT,	"REL|SOFT"	},	\
>   		{ HRTIMER_MODE_ABS_PINNED_SOFT,	"ABS|PINNED|SOFT" },	\
> -		{ HRTIMER_MODE_REL_PINNED_SOFT,	"REL|PINNED|SOFT" })
> +		{ HRTIMER_MODE_REL_PINNED_SOFT,	"REL|PINNED|SOFT" },	\
> +		{ HRTIMER_MODE_ABS_HARD,	"ABS|HARD" },		\
> +		{ HRTIMER_MODE_REL_HARD,	"REL|HARD" },		\
> +		{ HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" },	\
> +		{ HRTIMER_MODE_REL_PINNED_HARD,	"REL|PINNED|HARD" })
>   
>   /**
>    * hrtimer_init - called when the hrtimer is initialized