linux-kernel - Re: [PATCH V6 3/3] rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202304200018.ik0k7dKN-lkp@intel.com>
Date:   Thu, 20 Apr 2023 01:03:28 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sarannya S <quic_sarannya@...cinc.com>, quic_bjorande@...cinc.com,
        arnaud.pouliquen@...s.st.com, swboyd@...omium.org,
        quic_clew@...cinc.com, mathieu.poirier@...aro.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        Sarannya S <quic_sarannya@...cinc.com>,
        Deepak Kumar Singh <quic_deesin@...cinc.com>,
        Bjorn Andersson <andersson@...nel.org>
Subject: Re: [PATCH V6 3/3] rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL
 support

Hi Sarannya,

kernel test robot noticed the following build errors:

[auto build test ERROR on v6.3-rc7]
[also build test ERROR on linus/master next-20230418]
[cannot apply to remoteproc/rpmsg-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sarannya-S/rpmsg-core-Add-signal-API-support/20230419-220040
patch link:    https://lore.kernel.org/r/1681912409-25248-4-git-send-email-quic_sarannya%40quicinc.com
patch subject: [PATCH V6 3/3] rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230420/202304200018.ik0k7dKN-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/4f765ede8c129f07c522ef4a7c6aee27cb466be6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sarannya-S/rpmsg-core-Add-signal-API-support/20230419-220040
        git checkout 4f765ede8c129f07c522ef4a7c6aee27cb466be6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304200018.ik0k7dKN-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/rpmsg/rpmsg_char.c: In function 'rpmsg_eptdev_ioctl':
>> drivers/rpmsg/rpmsg_char.c:334:23: error: too few arguments to function 'rpmsg_set_flow_control'
     334 |                 ret = rpmsg_set_flow_control(eptdev->ept, set);
         |                       ^~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/rpmsg/rpmsg_char.c:23:
   include/linux/rpmsg.h:200:5: note: declared here
     200 | int rpmsg_set_flow_control(struct rpmsg_endpoint *ept, bool enable, u32 dst);
         |     ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/rpmsg/rpmsg_char.c:321:13: warning: variable 'val' set but not used [-Wunused-but-set-variable]
     321 |         u32 val;
         |             ^~~


vim +/rpmsg_set_flow_control +334 drivers/rpmsg/rpmsg_char.c

   314	
   315	static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd,
   316				       unsigned long arg)
   317	{
   318		struct rpmsg_eptdev *eptdev = fp->private_data;
   319	
   320		bool set;
 > 321		u32 val;
   322		int ret;
   323	
   324		switch (cmd) {
   325		case RPMSG_GET_OUTGOING_FLOWCONTROL:
   326			eptdev->remote_flow_updated = false;
   327			ret = put_user(eptdev->remote_flow, (int __user *)arg);
   328			break;
   329		case RPMSG_SET_INCOMING_FLOWCONTROL:
   330			ret = get_user(val, (int __user *)arg);
   331			if (ret)
   332				break;
   333			set = !!arg;
 > 334			ret = rpmsg_set_flow_control(eptdev->ept, set);
   335			break;
   336		case RPMSG_DESTROY_EPT_IOCTL:
   337			/* Don't allow to destroy a default endpoint. */
   338			if (eptdev->default_ept) {
   339				ret = -EINVAL;
   340				break;
   341			}
   342			ret = rpmsg_chrdev_eptdev_destroy(&eptdev->dev, NULL);
   343			break;
   344		default:
   345			ret = -EINVAL;
   346		}
   347	
   348		return ret;
   349	}
   350	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests