linux-kernel - Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae80b632-65df-eee9-11d5-03dc957c8a3a@gmail.com>
Date:   Wed, 19 Apr 2023 11:48:11 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-pci@...r.kernel.org,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        Yue Wang <yue.wang@...ogic.com>
Subject: Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt

On 4/18/23 11:40, Bjorn Helgaas wrote:
> On Tue, Apr 18, 2023 at 11:10:39AM -0700, Florian Fainelli wrote:
>> On 4/18/23 10:43, Bjorn Helgaas wrote:
>>> From: Bjorn Helgaas <bhelgaas@...gle.com>
>>>
>>> Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
>>> match other PCIe drivers.  Capitalize "Meson" to match other Meson Kconfig
>>> prompts.
>>
>> Did you mean, do not capitalize "Meson" or did you intend to preserve the
>> previous hunk that had "Meson" capitalized?
> 
> I made it match other Meson prompts:
> 
>    arch/arm/mach-meson/Kconfig-    bool "Amlogic Meson6 (8726MX) SoCs support"
>    drivers/char/hw_random/Kconfig- tristate "Amlogic Meson Random Number Generator support"
>    drivers/clk/meson/Kconfig-      bool "Meson8 SoC Clock controller support"
>    drivers/gpu/drm/meson/Kconfig-  tristate "DRM Support for Amlogic Meson Display Controller"
>    drivers/i2c/busses/Kconfig-     tristate "Amlogic Meson I2C controller"
>    drivers/iio/adc/Kconfig-        tristate "Amlogic Meson SAR ADC driver"
>    drivers/media/cec/platform/Kconfig-     tristate "Amlogic Meson AO CEC driver"
> 
> So I guess could have described as "style Meson with initial cap only
> instead of all caps" or something.

This is fine, I was just reading it wrong, as meaning all capital 
letters. Thanks.
-- 
Florian