linux-kernel - Re: linux-next: Build failure after merge of the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Apr 2023 20:50:05 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     broonie@...nel.org
Cc:     David Hildenbrand <david@...hat.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Rick Edgecombe <rick.p.edgecombe@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>,
        Mike Rapoport <rppt@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Peter Xu <peterx@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Build failure after merge of the tip tree

On Wed, Apr 19, 2023 at 07:21:36PM +0100, broonie@...nel.org wrote:
> Hi all,
> 
> After merging the rcu tree, today's linux-next build (arm64 defconfig)
> failed like this:
> 
> /tmp/next/build/mm/migrate.c: In function 'remove_migration_pte':
> /tmp/next/build/mm/migrate.c:222:31: error: too few arguments to function 'pte_mkwrite'
>   222 |                         pte = pte_mkwrite(pte);
>       |                               ^~~~~~~~~~~
> In file included from /tmp/next/build/include/linux/pgtable.h:6,
>                  from /tmp/next/build/include/linux/mm.h:29,
>                  from /tmp/next/build/include/linux/migrate.h:5,
>                  from /tmp/next/build/mm/migrate.c:16:
> /tmp/next/build/arch/arm64/include/asm/pgtable.h:190:21: note: declared here
>   190 | static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma)
>       |                     ^~~~~~~~~~~
> 
> Caused by commit
> 
>   717f95b494ac36 ("mm: don't check VMA write permissions if the PTE/PMD indicates write permissions")
> 
> from the mm tree interacting with
> 
>   74fd30bd28e4c7 ("mm: Make pte_mkwrite() take a VMA")
> 
> from the tip tree.  I've applied the fixup below

Thanks for letting us know - we'll keep this in mind when sending the
piles of patches to Linus next week.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette