linux-kernel - Re: [PATCH 1/4] block: constify partition prober array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202304200454.r3d73iaw-lkp@intel.com>
Date:   Thu, 20 Apr 2023 04:18:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Thomas Weißschuh <linux@...ssschuh.net>,
        Jens Axboe <axboe@...nel.dk>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Thomas Weißschuh <linux@...ssschuh.net>
Subject: Re: [PATCH 1/4] block: constify partition prober array

Hi Thomas,

kernel test robot noticed the following build warnings:

[auto build test WARNING on af67688dca57999fd848f051eeea1d375ba546b2]

url:    https://github.com/intel-lab-lkp/linux/commits/Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356
base:   af67688dca57999fd848f051eeea1d375ba546b2
patch link:    https://lore.kernel.org/r/20230419-const-partition-v1-1-2d66f2d83873%40weissschuh.net
patch subject: [PATCH 1/4] block: constify partition prober array
config: x86_64-randconfig-s023 (https://download.01.org/0day-ci/archive/20230420/202304200454.r3d73iaw-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/9bc1f4308c10322c327c9e86ede6bb9e862440aa
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356
        git checkout 9bc1f4308c10322c327c9e86ede6bb9e862440aa
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 olddefconfig
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304200454.r3d73iaw-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> block/partitions/core.c:24:9: sparse: sparse: incorrect type in initializer (different modifiers) @@     expected int ( const * )( ... ) @@     got int ( * )( ... ) @@
   block/partitions/core.c:24:9: sparse:     expected int ( const * )( ... )
   block/partitions/core.c:24:9: sparse:     got int ( * )( ... )
   block/partitions/core.c:47:9: sparse: sparse: incorrect type in initializer (different modifiers) @@     expected int ( const * )( ... ) @@     got int ( * )( ... ) @@
   block/partitions/core.c:47:9: sparse:     expected int ( const * )( ... )
   block/partitions/core.c:47:9: sparse:     got int ( * )( ... )
   block/partitions/core.c:53:9: sparse: sparse: incorrect type in initializer (different modifiers) @@     expected int ( const * )( ... ) @@     got int ( * )( ... ) @@
   block/partitions/core.c:53:9: sparse:     expected int ( const * )( ... )
   block/partitions/core.c:53:9: sparse:     got int ( * )( ... )
   block/partitions/core.c:56:9: sparse: sparse: incorrect type in initializer (different modifiers) @@     expected int ( const * )( ... ) @@     got int ( * )( ... ) @@
   block/partitions/core.c:56:9: sparse:     expected int ( const * )( ... )
   block/partitions/core.c:56:9: sparse:     got int ( * )( ... )
   block/partitions/core.c:68:9: sparse: sparse: incorrect type in initializer (different modifiers) @@     expected int ( const * )( ... ) @@     got int ( * )( ... ) @@
   block/partitions/core.c:68:9: sparse:     expected int ( const * )( ... )
   block/partitions/core.c:68:9: sparse:     got int ( * )( ... )
   block/partitions/core.c:71:9: sparse: sparse: incorrect type in initializer (different modifiers) @@     expected int ( const * )( ... ) @@     got int ( * )( ... ) @@
   block/partitions/core.c:71:9: sparse:     expected int ( const * )( ... )
   block/partitions/core.c:71:9: sparse:     got int ( * )( ... )

vim +24 block/partitions/core.c

387048bf67eeff Christoph Hellwig 2020-03-24  14  
9bc1f4308c1032 Thomas Weißschuh  2023-04-19  15  static const int (*check_part[])(struct parsed_partitions *) = {
387048bf67eeff Christoph Hellwig 2020-03-24  16  	/*
387048bf67eeff Christoph Hellwig 2020-03-24  17  	 * Probe partition formats with tables at disk address 0
387048bf67eeff Christoph Hellwig 2020-03-24  18  	 * that also have an ADFS boot block at 0xdc0.
387048bf67eeff Christoph Hellwig 2020-03-24  19  	 */
387048bf67eeff Christoph Hellwig 2020-03-24  20  #ifdef CONFIG_ACORN_PARTITION_ICS
387048bf67eeff Christoph Hellwig 2020-03-24  21  	adfspart_check_ICS,
387048bf67eeff Christoph Hellwig 2020-03-24  22  #endif
387048bf67eeff Christoph Hellwig 2020-03-24  23  #ifdef CONFIG_ACORN_PARTITION_POWERTEC
387048bf67eeff Christoph Hellwig 2020-03-24 @24  	adfspart_check_POWERTEC,
387048bf67eeff Christoph Hellwig 2020-03-24  25  #endif
387048bf67eeff Christoph Hellwig 2020-03-24  26  #ifdef CONFIG_ACORN_PARTITION_EESOX
387048bf67eeff Christoph Hellwig 2020-03-24  27  	adfspart_check_EESOX,
387048bf67eeff Christoph Hellwig 2020-03-24  28  #endif
387048bf67eeff Christoph Hellwig 2020-03-24  29  
387048bf67eeff Christoph Hellwig 2020-03-24  30  	/*
387048bf67eeff Christoph Hellwig 2020-03-24  31  	 * Now move on to formats that only have partition info at
387048bf67eeff Christoph Hellwig 2020-03-24  32  	 * disk address 0xdc0.  Since these may also have stale
387048bf67eeff Christoph Hellwig 2020-03-24  33  	 * PC/BIOS partition tables, they need to come before
387048bf67eeff Christoph Hellwig 2020-03-24  34  	 * the msdos entry.
387048bf67eeff Christoph Hellwig 2020-03-24  35  	 */
387048bf67eeff Christoph Hellwig 2020-03-24  36  #ifdef CONFIG_ACORN_PARTITION_CUMANA
387048bf67eeff Christoph Hellwig 2020-03-24  37  	adfspart_check_CUMANA,
387048bf67eeff Christoph Hellwig 2020-03-24  38  #endif
387048bf67eeff Christoph Hellwig 2020-03-24  39  #ifdef CONFIG_ACORN_PARTITION_ADFS
387048bf67eeff Christoph Hellwig 2020-03-24  40  	adfspart_check_ADFS,
387048bf67eeff Christoph Hellwig 2020-03-24  41  #endif
387048bf67eeff Christoph Hellwig 2020-03-24  42  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests