linux-kernel - Re: [PATCH] maple_tree: Fix allocation in mas_sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230419211147.oyqxns7t3c6vlh7i@revolver>
Date:   Wed, 19 Apr 2023 17:11:47 -0400
From:   "Liam R. Howlett" <Liam.Howlett@...cle.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Peng Zhang <zhangpeng.00@...edance.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, maple-tree@...ts.infradead.org
Subject: Re: [PATCH] maple_tree: Fix allocation in mas_sparse_area()

* Andrew Morton <akpm@...ux-foundation.org> [230419 15:49]:
> On Wed, 19 Apr 2023 17:36:25 +0800 Peng Zhang <zhangpeng.00@...edance.com> wrote:
> 
> > In the case of reverse allocation, mas->index and mas->last do not point
> > to the correct allocation range, which will cause users to get incorrect
> > allocation results, so fix it. If the user does not use it in a specific
> > way, this bug will not be triggered.
> 
> Please describe the user-visible effects of the bug.  I assume "none",
> because there are presently no callers which can trigger it?

Yes, sparse nodes are not enabled at this time.

> 
> > Also re-checks whether the size is still satisfied after the lower bound
> > was increased, which is a corner case and is incorrect in previous versions.
> 
> Again, what are the user-visible effects of the bug?

Correct, none.