linux-kernel - Re: [PATCH v2 5/9] regulator: rt5033: Change regulator names to lowercase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Apr 2023 00:21:26 +0200
From:   Jakob Hauser <jahau@...ketmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Sebastian Reichel <sre@...nel.org>, Lee Jones <lee@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Beomho Seo <beomho.seo@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Stephan Gerhold <stephan@...hold.net>,
        Raymond Hackley <raymondhackley@...tonmail.com>,
        Pavel Machek <pavel@....cz>, Axel Lin <axel.lin@...ics.com>,
        ChiYuan Huang <cy_huang@...htek.com>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 5/9] regulator: rt5033: Change regulator names to
 lowercase

Hi Krzysztof,

On 19.04.23 10:40, Krzysztof Kozlowski wrote:
> On 18/04/2023 23:24, Jakob Hauser wrote:
>> On 16.04.23 20:32, Krzysztof Kozlowski wrote:
>>> On 16/04/2023 14:44, Jakob Hauser wrote:
>>>> Lowercase is preferred for node names.
>>>
>>> This will break all existing users. In-tree and out-of-tree. Where is
>>> the binding update?
>>
>> In my reply to Rob's comments in v1 I was pointing out that this will
>> affect an existing driver. There was no reaction.
>>
>> As far as I can see, there is no in-tree usage yet. Though I can't tell
>> about out-of-tree usage. Although if there is, adding the rt5033-charger
>> driver might already causes the need for changes.
>>
>> Well, to stay on the safe side, I'll drop this patch in v3 and will
>> change the bindings (patch 9) back to uppercase.
> 
> Your v1 binding patch did not explain that you document existing ABI, so
> you got comments like for a new binding. This is not really new binding,
> is it?

The bindings for the mfd and regulator are new, even though the drivers 
are already existing. Sorry for not being clear on this in v1. This is 
due to historic reasons of the old patchset, more information on that 
further down.

The current situation in the mainline kernel is as follows.

drivers
-------
rt5033:            drivers/mfd/rt5033.c
rt5033-regulator:  drivers/regulator/rt5033-regulator.c
rt5033-charger:    not existent
rt5033-battery:    drivers/power/supply/rt5033_battery.c
rt5033-leds:       not existent

bindings
--------
rt5033:            not existent
rt5033-regulator:  not existent
rt5033-charger:    not existent
rt5033-battery:    .../bindings/power/supply/richtek,rt5033-battery.yaml
rt5033-leds:       not existent

The reason for that discrepancy:
RT5033 mfd, regulator and fuelgauge drivers were applied but charger & 
documentation didn't make [1]. They were submitted again but it phased 
out at that point, last known state is [2]. The LEDs are also a phased 
out patchset [3]. The fuelgauge binding was added not so long ago by 
Stephan [4].

[1] 
https://lore.kernel.org/all/1421899601-19327-1-git-send-email-beomho.seo@samsung.com/T/#t
[2] 
https://lore.kernel.org/lkml/1425864191-4121-1-git-send-email-beomho.seo@samsung.com/T/#t
[3] 
https://lore.kernel.org/linux-leds/1448446948-13729-1-git-send-email-ingi2.kim@samsung.com/T/#u
[4] 
https://lore.kernel.org/linux-devicetree/20210517105113.240379-1-stephan@gerhold.net/T/#m197b5719a5d37b17ba4ff9f3b3ff4bd4efcda71e

Kind regards,
Jakob