linux-kernel - [PATCH] scsi: core: Avoid doing rescan on suspended device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230419054112.269734-1-kai.heng.feng@canonical.com>
Date:   Wed, 19 Apr 2023 13:41:12 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     jejb@...ux.ibm.com, martin.petersen@...cle.com
Cc:     acelan.kao@...onical.com,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: core: Avoid doing rescan on suspended device

During system resume, if an EH is schduled after ATA host is resumed
(i.e. ATA_PFLAG_PM_PENDING cleared), but before the disk device is
resumed, the device_lock hold by scsi_rescan_device() is never released
so the dpm_resume() of the disk is blocked forerver.

That's because scsi_attach_vpd() is expecting the disk device is in
operational state, as it doesn't work on suspended device.

To avoid such deadlock, avoid doing rescan if the disk is still
suspended so the resume process of the disk device can proceed.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
---
 drivers/scsi/scsi_scan.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index d217be323cc6..36680cb1535b 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1621,6 +1621,9 @@ void scsi_rescan_device(struct device *dev)
 {
 	struct scsi_device *sdev = to_scsi_device(dev);

+	if (dev->power.is_prepared)
+		return;
+
 	device_lock(dev);

 	scsi_attach_vpd(sdev);
-- 
2.34.1