linux-kernel - Re: [PATCH] PCI: Add ASPEED vendor ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1f776e1-8489-010f-a500-ba68b45ad3a3@suse.de>
Date:   Wed, 19 Apr 2023 09:00:15 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Patrick McLean <chutzpah@...too.org>,
        Dave Airlie <airlied@...hat.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "open list:DRM DRIVER FOR AST SERVER GRAPHICS CHIPS" 
        <dri-devel@...ts.freedesktop.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] PCI: Add ASPEED vendor ID

Hi

Am 19.04.23 um 00:57 schrieb Patrick McLean:
> Currently the ASPEED PCI vendor ID is defined in
> drivers/gpu/drm/ast/ast_drv.c, move that to include/linux/pci_ids.h
> with all the rest of the PCI vendor ID definitions. Rename the definition
> to follow the format that the other definitions follow.

Thanks a lot. Can you please also move and rename the PCI device ids? [1]

Best regards
Thomas

[1] 
https://elixir.bootlin.com/linux/v6.2/source/drivers/gpu/drm/ast/ast_drv.h#L52

> 
> Signed-off-by: Patrick McLean <chutzpah@...too.org>
> ---
>   drivers/gpu/drm/ast/ast_drv.c | 4 +---
>   include/linux/pci_ids.h       | 2 ++
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
> index d78852c7cf5b..232e797793b6 100644
> --- a/drivers/gpu/drm/ast/ast_drv.c
> +++ b/drivers/gpu/drm/ast/ast_drv.c
> @@ -70,12 +70,10 @@ static const struct drm_driver ast_driver = {
>    * PCI driver
>    */
>   
> -#define PCI_VENDOR_ASPEED 0x1a03
> -
>   #define AST_VGA_DEVICE(id, info) {		\
>   	.class = PCI_BASE_CLASS_DISPLAY << 16,	\
>   	.class_mask = 0xff0000,			\
> -	.vendor = PCI_VENDOR_ASPEED,			\
> +	.vendor = PCI_VENDOR_ID_ASPEED,			\
>   	.device = id,				\
>   	.subvendor = PCI_ANY_ID,		\
>   	.subdevice = PCI_ANY_ID,		\
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 45c3d62e616d..40e04e88ca5a 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2553,6 +2553,8 @@
>   #define PCI_DEVICE_ID_NETRONOME_NFP3800_VF	0x3803
>   #define PCI_DEVICE_ID_NETRONOME_NFP6000_VF	0x6003
>   
> +#define PCI_VENDOR_ID_ASPEED		0x1a03
> +
>   #define PCI_VENDOR_ID_QMI		0x1a32
>   
>   #define PCI_VENDOR_ID_AZWAVE		0x1a3b

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)