linux-kernel - Re: [PATCH v4] vfio/cdx: add support for CDX bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZD8wmF4DALTRyWmO@ziepe.ca>
Date:   Tue, 18 Apr 2023 21:06:48 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     "Gupta, Nipun" <Nipun.Gupta@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "nathan@...nel.org" <nathan@...nel.org>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>,
        "nicolas@...sle.eu" <nicolas@...sle.eu>,
        "git (AMD-Xilinx)" <git@....com>,
        "Anand, Harpreet" <harpreet.anand@....com>,
        "Jansen Van Vuuren, Pieter" <pieter.jansen-van-vuuren@....com>,
        "Agarwal, Nikhil" <nikhil.agarwal@....com>,
        "Simek, Michal" <michal.simek@....com>
Subject: Re: [PATCH v4] vfio/cdx: add support for CDX bus

On Tue, Apr 18, 2023 at 02:40:20PM -0600, Alex Williamson wrote:
> On Tue, 18 Apr 2023 12:50:13 +0000
> "Gupta, Nipun" <Nipun.Gupta@....com> wrote:
> 
> > > -----Original Message-----
> > > From: Jason Gunthorpe <jgg@...pe.ca>
> > > Sent: Tuesday, April 18, 2023 5:40 PM
> > > To: Gupta, Nipun <Nipun.Gupta@....com>
> > > Cc: alex.williamson@...hat.com; linux-kernel@...r.kernel.org;
> > > kvm@...r.kernel.org; masahiroy@...nel.org; nathan@...nel.org;
> > > ndesaulniers@...gle.com; nicolas@...sle.eu; git (AMD-Xilinx) <git@....com>;
> > > Anand, Harpreet <harpreet.anand@....com>; Jansen Van Vuuren, Pieter
> > > <pieter.jansen-van-vuuren@....com>; Agarwal, Nikhil
> > > <nikhil.agarwal@....com>; Simek, Michal <michal.simek@....com>
> > > Subject: Re: [PATCH v4] vfio/cdx: add support for CDX bus
> > > 
> > > Caution: This message originated from an External Source. Use proper caution
> > > when opening attachments, clicking links, or responding.
> > > 
> > > 
> > > On Tue, Apr 18, 2023 at 05:06:55PM +0530, Nipun Gupta wrote:
> > >   
> > > > diff --git a/drivers/vfio/Kconfig b/drivers/vfio/Kconfig
> > > > index 89e06c981e43..aba36f5be4ec 100644
> > > > --- a/drivers/vfio/Kconfig
> > > > +++ b/drivers/vfio/Kconfig
> > > > @@ -57,6 +57,7 @@ source "drivers/vfio/pci/Kconfig"
> > > >  source "drivers/vfio/platform/Kconfig"
> > > >  source "drivers/vfio/mdev/Kconfig"
> > > >  source "drivers/vfio/fsl-mc/Kconfig"
> > > > +source "drivers/vfio/cdx/Kconfig"  
> > > 
> > > keep sorted  
> > 
> > Since it is not sorted as of now, should a separate patch to be created for
> > sorting, before adding vfio-cdx?
> 
> These are essentially in chronological order rather than alphabetical,
> so I don't really understand this request from Jason.  Perhaps if it
> was already alphabetical the request would be justified, but I don't
> see any obligation here.

Ah, well knee jerk, I keep sorting these things, guess I haven't go
here yet.

Best practice is to sort lists like this.

Jason