linux-kernel - RE: [PATCH] driver core: auxiliary bus: No need to get auxdev->dev again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TY2PR06MB3424FD1DF9CE50F1E5AED1CB85629@TY2PR06MB3424.apcprd06.prod.outlook.com>
Date:   Wed, 19 Apr 2023 01:02:15 +0000
From:   Angus Chen <angus.chen@...uarmicro.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "rafael@...nel.org" <rafael@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] driver core: auxiliary bus: No need to get auxdev->dev
 again



> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Tuesday, April 18, 2023 8:32 PM
> To: Angus Chen <angus.chen@...uarmicro.com>
> Cc: rafael@...nel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] driver core: auxiliary bus: No need to get auxdev->dev
> again
> 
> On Tue, Apr 18, 2023 at 08:24:06PM +0800, Angus Chen wrote:
> > Use dev variable directly.
> > No functional change intended.
> 
> Not intended, but is it really intended?  What does this line mean?
> 
> >
> > Signed-off-by: Angus Chen <angus.chen@...uarmicro.com>
> > ---
> >  drivers/base/auxiliary.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> > index 4d4c2c8d26c4..ca1d044ff738 100644
> > --- a/drivers/base/auxiliary.c
> > +++ b/drivers/base/auxiliary.c
> > @@ -286,7 +286,7 @@ int auxiliary_device_init(struct auxiliary_device
> *auxdev)
> >  	}
> >
> >  	dev->bus = &auxiliary_bus_type;
> > -	device_initialize(&auxdev->dev);
> > +	device_initialize(dev);
> 
> While an interesting change, is it needed?  Why make it?
I mean it just a clean up.beacuse
struct device *dev = &auxdev->dev;
thanks.

> 
> thanks,
> 
> greg k-h