linux-kernel - Re: [PATCH] kunit: drm: make DRM buddy test compatible with other pages sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOSkMBCAe9sbUV8LauvLbc97B1bKKrm=4HEzF8K1UMz_dDw@mail.gmail.com>
Date:   Wed, 19 Apr 2023 16:27:31 +0800
From:   David Gow <davidgow@...gle.com>
To:     Nico Pache <npache@...hat.com>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        matthew.auld@...el.com, arunpravin.paneerselvam@....com,
        arthurgrillo@...eup.net, javierm@...hat.com,
        christian.koenig@....com, mairacanal@...eup.net, daniel@...ll.ch,
        airlied@...il.com, ddutile@...hat.com, kunit-dev@...glegroups.com
Subject: Re: [PATCH] kunit: drm: make DRM buddy test compatible with other
 pages sizes

On Wed, 19 Apr 2023 at 01:15, Nico Pache <npache@...hat.com> wrote:
>
> The DRM buddy test uses a fixed 12 bit shift to covert from pages to
> bytes. This number is then used to confirm that (chunk_size < PAGE_SIZE)
> which can lead to a failing drm_buddy_init on systems with PAGE_SIZE > 4k.
>
> Fixes: 92937f170d3f ("drm/selftests: add drm buddy alloc range testcase")
> Signed-off-by: Nico Pache <npache@...hat.com>
> ---

Nice catch! This makes sense to me (and doesn't regress anything on my
various 4k-page machines, at least).

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David


>  drivers/gpu/drm/tests/drm_buddy_test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c
> index 09ee6f6af896..a62b2690d3c2 100644
> --- a/drivers/gpu/drm/tests/drm_buddy_test.c
> +++ b/drivers/gpu/drm/tests/drm_buddy_test.c
> @@ -318,8 +318,8 @@ static void mm_config(u64 *size, u64 *chunk_size)
>         s &= -ms;
>
>         /* Convert from pages to bytes */
> -       *chunk_size = (u64)ms << 12;
> -       *size = (u64)s << 12;
> +       *chunk_size = (u64)ms << PAGE_SHIFT;
> +       *size = (u64)s << PAGE_SHIFT;
>  }
>
>  static void drm_test_buddy_alloc_pathological(struct kunit *test)
> --
> 2.39.2
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)