linux-kernel - Re: [PATCH] sh: sq: Fix incorrect element size for allocating bitmap buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdV9PynJKN9=UX3+t1orWJiPusbsELPybLN_UVnykDH9Mw@mail.gmail.com>
Date:   Wed, 19 Apr 2023 13:58:43 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Lorenzo Stoakes <lstoakes@...il.com>,
        Baoquan He <bhe@...hat.com>,
        "Uladzislau Rezki (Sony)" <urezki@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Paul Mundt <lethal@...ux-sh.org>, linux-sh@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sh: sq: Fix incorrect element size for allocating bitmap buffer

On Wed, Apr 19, 2023 at 1:55 PM John Paul Adrian Glaubitz
<glaubitz@...sik.fu-berlin.de> wrote:
> The Store Queue code allocates a bitmap buffer with the size of
> multiple of sizeof(long) in sq_api_init(). While the buffer size
> is calculated correctly, the code uses the wrong element size to
> allocate the buffer which results in the allocated bitmap buffer
> being too small.
>
> Fix this by allocating the buffer with kcalloc() with element size
> sizeof(long) instead of kzalloc() whose elements size defaults to
> sizeof(char).
>
> Fixes: d7c30c682a27 ("sh: Store Queue API rework.")
> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds