linux-kernel - Re: [PATCH v2 2/7] arm64: dts: imx93-11x11-evk: added ele-mu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c568f571-22ee-0d85-043f-4673d76bf364@linaro.org>
Date:   Wed, 19 Apr 2023 15:02:44 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Pankaj Gupta <pankaj.gupta@....com>, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        gaurav.jain@....com, sahil.malhotra@....com, aisheng.dong@....com,
        V.Sethi@....com
Subject: Re: [PATCH v2 2/7] arm64: dts: imx93-11x11-evk: added ele-mu

On 19/04/2023 19:55, Pankaj Gupta wrote:
> adde support for ele-mu for imx93-11x11-evk.

Typo, missing capital letter.

> 
> Signed-off-by: Pankaj Gupta <pankaj.gupta@....com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 41efd97dd6d6..ffb7cb8ed228 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>  /*
> - * Copyright 2022 NXP
> + * Copyright 2022-2022 NXP

?


>   */
>  
>  #include <dt-bindings/clock/imx93-clock.h>
> @@ -741,5 +741,14 @@ media_blk_ctrl: system-controller@...10000 {
>  			#power-domain-cells = <1>;
>  			status = "disabled";
>  		};

Missing blank line.

> +		ele_mu: ele-mu {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +			compatible = "fsl,imx93-ele";
> +			mboxes = <&s4muap 0 0 &s4muap 1 0>;

Two phandles, not one.

> +			mbox-names = "tx", "rx";
> +			fsl,ele_mu_did = <3>;
> +			fsl,ele_mu_id = <2>;
> +			fsl,ele_mu_max_users = <4>;
> +			status = "okay";

Why do you need it?

Run your patches through internal review to fix such obvious mistakes.
There is entire NXP to help you, instead of relying on us to fix trivial
code style.

> +		};
>  	};
>  };

Best regards,
Krzysztof