linux-kernel - Re: [PATCH 1/4] block: constify partition prober array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 19 Apr 2023 21:29:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Thomas Weißschuh <linux@...ssschuh.net>,
        Jens Axboe <axboe@...nel.dk>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thomas Weißschuh <linux@...ssschuh.net>
Subject: Re: [PATCH 1/4] block: constify partition prober array

Hi Thomas,

kernel test robot noticed the following build warnings:

[auto build test WARNING on af67688dca57999fd848f051eeea1d375ba546b2]

url:    https://github.com/intel-lab-lkp/linux/commits/Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356
base:   af67688dca57999fd848f051eeea1d375ba546b2
patch link:    https://lore.kernel.org/r/20230419-const-partition-v1-1-2d66f2d83873%40weissschuh.net
patch subject: [PATCH 1/4] block: constify partition prober array
config: arm64-randconfig-r001-20230416 (https://download.01.org/0day-ci/archive/20230419/202304192132.a6MR0cFR-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 437b7602e4a998220871de78afcb020b9c14a661)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/9bc1f4308c10322c327c9e86ede6bb9e862440aa
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356
        git checkout 9bc1f4308c10322c327c9e86ede6bb9e862440aa
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash block/partitions/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304192132.a6MR0cFR-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> block/partitions/core.c:15:8: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
   static const int (*check_part[])(struct parsed_partitions *) = {
          ^~~~~~
   block/partitions/core.c:47:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
           efi_partition,          /* this must come before msdos */
           ^~~~~~~~~~~~~
   block/partitions/core.c:50:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
           sgi_partition,
           ^~~~~~~~~~~~~
   block/partitions/core.c:56:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
           msdos_partition,
           ^~~~~~~~~~~~~~~
   block/partitions/core.c:59:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
           osf_partition,
           ^~~~~~~~~~~~~
   block/partitions/core.c:62:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
           sun_partition,
           ^~~~~~~~~~~~~
   block/partitions/core.c:65:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
           amiga_partition,
           ^~~~~~~~~~~~~~~
   block/partitions/core.c:71:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
           mac_partition,
           ^~~~~~~~~~~~~
   1 warning and 7 errors generated.


vim +/const +15 block/partitions/core.c

    14	
  > 15	static const int (*check_part[])(struct parsed_partitions *) = {
    16		/*
    17		 * Probe partition formats with tables at disk address 0
    18		 * that also have an ADFS boot block at 0xdc0.
    19		 */
    20	#ifdef CONFIG_ACORN_PARTITION_ICS
    21		adfspart_check_ICS,
    22	#endif
    23	#ifdef CONFIG_ACORN_PARTITION_POWERTEC
    24		adfspart_check_POWERTEC,
    25	#endif
    26	#ifdef CONFIG_ACORN_PARTITION_EESOX
    27		adfspart_check_EESOX,
    28	#endif
    29	
    30		/*
    31		 * Now move on to formats that only have partition info at
    32		 * disk address 0xdc0.  Since these may also have stale
    33		 * PC/BIOS partition tables, they need to come before
    34		 * the msdos entry.
    35		 */
    36	#ifdef CONFIG_ACORN_PARTITION_CUMANA
    37		adfspart_check_CUMANA,
    38	#endif
    39	#ifdef CONFIG_ACORN_PARTITION_ADFS
    40		adfspart_check_ADFS,
    41	#endif
    42	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests