linux-kernel - Re: [PATCH] wireless: airo: remove ISA_DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZD/t5VARDjrloYdG@corigine.com>
Date:   Wed, 19 Apr 2023 15:34:29 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wireless: airo: remove ISA_DMA_API dependency

On Mon, Apr 17, 2023 at 10:51:24PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This driver does not actually use the ISA DMA API, it is purely
> PIO based, so remove the dependency.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Hi Arnd,

I think that the subject prefix should probably be 'wifi: airo: '.
That nit aside, FWIIW, this looks good to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>


> ---
>  drivers/net/wireless/cisco/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/cisco/Kconfig b/drivers/net/wireless/cisco/Kconfig
> index 681bfc2d740a..b40ee25aca99 100644
> --- a/drivers/net/wireless/cisco/Kconfig
> +++ b/drivers/net/wireless/cisco/Kconfig
> @@ -14,7 +14,7 @@ if WLAN_VENDOR_CISCO
>  
>  config AIRO
>  	tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
> -	depends on CFG80211 && ISA_DMA_API && (PCI || BROKEN)
> +	depends on CFG80211 && (PCI || BROKEN)
>  	select WIRELESS_EXT
>  	select CRYPTO
>  	select CRYPTO_SKCIPHER
> -- 
> 2.39.2
>